Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIP] Reclaiming hipLaunchKernel API #1353

Merged
merged 4 commits into from
Aug 29, 2019
Merged

[HIP] Reclaiming hipLaunchKernel API #1353

merged 4 commits into from
Aug 29, 2019

Conversation

SarbojitAMD
Copy link
Contributor

Reclaiming the old deprecated hipLaunchKernel symbol to implement hipLaunchKernel that matches cudaLaunchKernel signature.

Note: Incorporated all review comments

@SarbojitAMD SarbojitAMD mentioned this pull request Aug 21, 2019
Closed
gargrahul
gargrahul requested changes Aug 21, 2019
View reviewed changes
src/hip_module.cpp Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
mangupta
mangupta requested changes Aug 22, 2019
View reviewed changes
src/hip_module.cpp Outdated Show resolved Hide resolved
tests/src/gcc/LaunchKernel.c Outdated Show resolved Hide resolved
@SarbojitAMD
Copy link
Contributor Author

SarbojitAMD commented Aug 26, 2019 •
edited
Loading

@gargrahul
In current change Host code will be compiled using gcc but test_common.h is not C compliant hence I could not use it.

@mangupta mangupta merged commit 5c4f78b into ROCm:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangupta mangupta mangupta approved these changes

@gargrahul gargrahul Awaiting requested review from gargrahul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarbojitAMD @gargrahul @mangupta